Repository navigation
Follow missing external alias inputs - #630
Merged
tinder-maxwellelliott merged 5 commits intoNov 8, 2026
Merged
tinder-maxwellelliott merged 5 commits into
tinder-maxwellelliott merged 5 commits into
Conversation
tamird
force-pushed
the
codex/bazel-diff-alias-acquisition-20261105
branch
2 times, most recently
from
November 7, 2026 04:02
7ba551f to
9ed4db3
Compare
An ordinary query can return an external alias without returning the library behind another alias. A source edit can then change the built consumer without selecting it. For aliases reached in repositories selected for individual target hashing, inspect native actual values and ask Bazel for dependencies and build files of distinct missing destinations. Reuse primary targets and preserve the caller's attribute projection. Full source hashing with fine repository options reads returned regular external files. Keep alias acquisition off before Bazel 8. Report supplemental errors in strict mode and retain the primary graph under keep-going. Resolve repository settings read from a file in snapshot identity and use partial recipe version 5, distinct from version 4 in Tinder#628. Assisted by Codex.
A generated BUILD can declare many aliases. Hashing it as an input of every forwarding alias made a version change to one sibling select unchanged users of another. The ordinary input list also loses which destination belongs to each condition when actual is projected out. Read native aliases' evaluated actual on both sides of the primary query boundary and use the existing attribute hasher for that binding. Keep BUILD and loaded Starlark inputs on the acquired terminal rules. Test a sibling edit and a selector swap with identical input labels both when destinations require acquisition and when they are already present. Renew the compatible snapshot and partial recipes.
The collector for fine repositories reads returned external files for full hashing, but partial generation skips that path. A fine alias can reach a source outside the named repositories while the partial recipe omits its digest. The existing product and graph reuse checks did not assert that this source was recorded. Allow partial generation to read returned regular sources through their canonical repository paths. Keep the previous resolver when the Git content map supplies either repository spelling, and preserve full source overrides. Reuse the existing recorder and advance the partial recipe version. Extend the regression for fine aliases to require both the saved source digest and the reported source hash to change after the real file edit, alongside the existing product and graph reuse checks. Assisted by Codex.
A fine alias can expose part of an external package while an ordinary alias names a different target there. The previous graph could omit that target and miss a consumer whose built output changed. Reuse the existing input walk to find those aliases. Verify native actual bindings, inventory matching packages where the fine traversal returned rules, and retain the returned dependencies of the named targets. The existing alias rehash preserves their complete bindings. Invalidate prior alias cache entries and partial recipes. Assisted by Codex.
A reached fine alias can point through returned literal aliases to a missing external target. The scan for missing inputs stopped at the first returned alias, so changing the external target's input could change a built consumer without selecting it. Inspect the returned native scalar bindings in batches and pass only missing destinations to the existing dependency query. Configurable ordinary aliases in the primary graph retain the existing package inventory behavior. Refresh cache and partial recipe identities so older graphs are regenerated. Assisted by Codex.
tamird
force-pushed
the
codex/bazel-diff-alias-acquisition-20261105
branch
from
November 7, 2026 16:51
56ac285 to
32164c8
Compare
This was referenced Nov 8, 2026
tinder-maxwellelliott
pushed a commit
that referenced
this pull request
Nov 9, 2026
When following a fine-grained external alias, deps() can return to another alias already in the primary query. Its duplicate row is discarded before bazel-diff reads the mapping from select conditions to destinations. Keep the name of each native alias reached in that query. Reread its actual attribute and apply it to the original row before hashing. Extend the #630 fixture with a filegroup that leads back into the hub. The build switches between two files whose labels stay in the input set. With a tags-only projection the alias and its consumer used to keep the same hash. A caller including Bazel's synthetic attribute fingerprint already detects this edit. Advance the cache and partial recipe versions so older alias hashes are regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
@publicnamed in--fineGrainedHashExternalRepos, changing the input behind@public//:forward→//:bridge→//:second_bridge→@library//:copychanges the built consumer frombeforetoafter. The previous graph stopped at an alias already returned by the primary query and missed the consumer.On Bazel 8+, follow verified native alias bindings and retain dependencies and BUILD files for missing destinations. Literal chains can pass through ordinary aliases already returned by the primary query. Configurable ordinary aliases in the primary graph use the existing inventory of matching external packages already represented by rule rows, and other attributes keep the caller's projection.
Returned regular external sources are hashed by content and recorded for partial reuse, with source overrides preserved. Updated cache and partial recipe identities regenerate older graphs.
Validation: stock Bazel 8.8.2 regressions for products and inactive branches; alias, query failure, and partial rebuild tests; Rust/CLI, Clippy, formatting, and case regeneration checks.
Assisted by Codex.